Allow parallel pipeline/shader compilation #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary for commit fc3c302Driver commits used in build
CTS tests (Failed: 0/225376)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
Parallel compilation is controlled by the `--num-threads` flag. We default to single-threaded compilation. The main goal is to excercise the threading in the compiler without having to run the full ICD on a machine with a GPU. With the thread sanitizer being enabled in our public CI, we hope that this will catch most of the potential synchronization issues in LLPC. Parallel compilation and verbose output are disallowed because of LLVM's ostream not being thread safe. Even if this wasn't the case, verbose logs would be interleaved and not very useful. Refactor stage processing such that `ShaderModuleData` mergin happens at the end.
|
V1. Fix typos. Rebase. |
vettoreldaniele
approved these changes
Dec 23, 2021
Test summary for commit 87cf7c6Driver commits used in build
CTS tests (Failed: 0/225376)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
amdrexu
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel compilation is controlled by the
--num-threadsflag.We default to single-threaded compilation.
The main goal is to excercise the threading in the compiler without
having to run the full ICD on a machine with a GPU. With the thread
sanitizer being enabled in our public CI, we hope that this will catch
most of the potential synchronization issues in LLPC.
Parallel compilation and verbose output are disallowed because of
LLVM's ostream not being thread safe. Even if this wasn't the case,
verbose logs would be interleaved and not very useful.
Refactor stage processing such that
ShaderModuleDatamergin happensat the end.