New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Upload code coverage report as GitHub artifact. #1627
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Daniele. I think this is actually a cleaner solution because it allows checks finish without any dependency on external services (google cloud).
08518b7
to
627b288
Compare
V1: Upload PR number as a text file artifact for later referencing by other workflows. This is recommended by GitHub as the PR number may not be always available (https://securitylab.github.com/research/github-actions-preventing-pwn-requests/). |
test this please |
Test summary for commit 627b288Driver commits used in build
CTS tests (Failed: 2/228192)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
retest this please |
Test summary for commit 627b288Driver commits used in build
CTS tests (Failed: 1/228192)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
retest this please |
Test summary for commit 627b288Driver commits used in build
CTS tests (Failed: 0/228192)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
Background: we are not able to access repository's secrets in CI triggered by a pull request from a fork, and therefore we are not able to upload code coverage reports to Google Cloud Storage since we can't authenticate.
This change instead uploads code coverage reports as GitHub artifacts, accessible from the CI Summary page. For example, see the Artifacts section at this example run: https://github.com/vettoreldaniele/llpc/actions/runs/1678664668.
Note: I will follow-up with another PR that adds a separate workflow to retrieve these artifacts and upload them to Google Cloud Storage, along with adding a comment to the original PR with a link to the report (similar to how it would have worked if the previous PR #1619 worked). That workflow should have access to the repository's secrets according to GitHub's docs.