Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upload code coverage report as GitHub artifact. #1627

Merged
merged 1 commit into from Jan 11, 2022

Conversation

vettoreldaniele
Copy link
Contributor

Background: we are not able to access repository's secrets in CI triggered by a pull request from a fork, and therefore we are not able to upload code coverage reports to Google Cloud Storage since we can't authenticate.

This change instead uploads code coverage reports as GitHub artifacts, accessible from the CI Summary page. For example, see the Artifacts section at this example run: https://github.com/vettoreldaniele/llpc/actions/runs/1678664668.

Note: I will follow-up with another PR that adds a separate workflow to retrieve these artifacts and upload them to Google Cloud Storage, along with adding a comment to the original PR with a link to the report (similar to how it would have worked if the previous PR #1619 worked). That workflow should have access to the repository's secrets according to GitHub's docs.

@vettoreldaniele vettoreldaniele requested a review from a team as a code owner January 10, 2022 18:25
@amdvlk-admin
Copy link
Collaborator

Can one of the admins verify this patch?

kuhar
kuhar previously approved these changes Jan 10, 2022
Copy link
Contributor

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, Daniele. I think this is actually a cleaner solution because it allows checks finish without any dependency on external services (google cloud).

@vettoreldaniele
Copy link
Contributor Author

V1: Upload PR number as a text file artifact for later referencing by other workflows. This is recommended by GitHub as the PR number may not be always available (https://securitylab.github.com/research/github-actions-preventing-pwn-requests/).

@kuhar
Copy link
Contributor

kuhar commented Jan 11, 2022

test this please

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 627b288

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev bcec463efe5260776d486a5e3da0c549bc0a75d2
  • SPVGEN: dev 580ade71d630a304805e9468ef22ad263c37d137
  • XGL: dev 04534321e450d220d404a240a047c7e1cd82f3fd
  • LLVM-PROJECT: amd-gfx-gpuopen-dev aaa34e134023e703e197a48d8069cf3a6ebea629
CTS tests (Failed: 2/228192)
  • Built with version 1.2.5.2
  • Rhel 8.2, Gfx10
    • Passed: 33955/57048 (59.5%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 23093/57048 (40.5%)
    • Warnings: 0/57048 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 33795/57048 (59.2%)
    • Failed: 2/57048 (0.0%)

      Failures:

      FAILURE: dEQP-VK.memory.pipeline_barrier.host_read_host_write.1048576
      Stack trace: Script:
      22:HostMemoryAccess Result differs from reference, Expected: 0x00000075, Got: 0x000000eb, At offset: 132075
      
      
      FAILURE: dEQP-VK.memory.pipeline_barrier.all.1048576_vertex_buffer_stride_4
      Stack trace: Script:
      31:HostMemoryAccess Result differs from reference, Expected: 0x00000073, Got: 0x00000059, At offset: 841836
      
      

    • Not Supported: 23250/57048 (40.8%)
    • Warnings: 1/57048 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 34085/57048 (59.7%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 22963/57048 (40.3%)
    • Warnings: 0/57048 (0.0%)
    Ubuntu 20.04, Gfx103
    • Passed: 35882/57048 (62.9%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 21166/57048 (37.1%)
    • Warnings: 0/57048 (0.0%)

@kuhar
Copy link
Contributor

kuhar commented Jan 11, 2022

retest this please

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 627b288

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev bcec463efe5260776d486a5e3da0c549bc0a75d2
  • SPVGEN: dev 580ade71d630a304805e9468ef22ad263c37d137
  • XGL: dev 04534321e450d220d404a240a047c7e1cd82f3fd
  • LLVM-PROJECT: amd-gfx-gpuopen-dev aaa34e134023e703e197a48d8069cf3a6ebea629
CTS tests (Failed: 1/228192)
  • Built with version 1.2.5.2
  • Rhel 8.2, Gfx10
    • Passed: 33955/57048 (59.5%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 23093/57048 (40.5%)
    • Warnings: 0/57048 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 33796/57048 (59.2%)
    • Failed: 1/57048 (0.0%)

      Failures:

      FAILURE: dEQP-VK.memory.pipeline_barrier.all.65536_vertex_buffer_stride_4
      Stack trace: Script:
      44:HostMemoryAccess Result differs from reference, Expected: 0x000000f0, Got: 0x000000d6, At offset: 29962
      
      

    • Not Supported: 23250/57048 (40.8%)
    • Warnings: 1/57048 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 34085/57048 (59.7%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 22963/57048 (40.3%)
    • Warnings: 0/57048 (0.0%)
    Ubuntu 20.04, Gfx103
    • Passed: 35882/57048 (62.9%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 21166/57048 (37.1%)
    • Warnings: 0/57048 (0.0%)

@kuhar
Copy link
Contributor

kuhar commented Jan 11, 2022

retest this please

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 627b288

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev bcec463efe5260776d486a5e3da0c549bc0a75d2
  • SPVGEN: dev 580ade71d630a304805e9468ef22ad263c37d137
  • XGL: dev 04534321e450d220d404a240a047c7e1cd82f3fd
  • LLVM-PROJECT: amd-gfx-gpuopen-dev aaa34e134023e703e197a48d8069cf3a6ebea629
CTS tests (Failed: 0/228192)
  • Built with version 1.2.5.2
  • Rhel 8.2, Gfx10
    • Passed: 33955/57048 (59.5%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 23093/57048 (40.5%)
    • Warnings: 0/57048 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 33797/57048 (59.2%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 23250/57048 (40.8%)
    • Warnings: 1/57048 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 34085/57048 (59.7%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 22963/57048 (40.3%)
    • Warnings: 0/57048 (0.0%)
    Ubuntu 20.04, Gfx103
    • Passed: 35882/57048 (62.9%)
    • Failed: 0/57048 (0.0%)
    • Not Supported: 21166/57048 (37.1%)
    • Warnings: 0/57048 (0.0%)

@kuhar kuhar merged commit ebf4903 into GPUOpen-Drivers:dev Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants