Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the remaining middle-end passes to the new pass manager #1682

Merged
merged 1 commit into from Feb 22, 2022
Merged

Port the remaining middle-end passes to the new pass manager #1682

merged 1 commit into from Feb 22, 2022

Conversation

bsaleil
Copy link
Contributor

@bsaleil bsaleil commented Feb 8, 2022 •
edited

Still needs additional testing and fixes before enabling the new pass manager by default.

@bsaleil bsaleil requested a review from a team as a code owner February 8, 2022 22:58
@bsaleil bsaleil requested a review from piotrAMD February 8, 2022 22:59
@bsaleil bsaleil force-pushed the npm-me-passes-3 branch 2 times, most recently from 7534fcf to ee83e6c Compare February 8, 2022 23:11
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_1815123927/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_1815123927/index.html.
Configuration: release_clang_coverage.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_1815129674/index.html.
Configuration: release_clang_coverage.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_1815129674/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_1815171677/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_1815171677/index.html.
Configuration: release_clang_coverage.

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 7534fcf

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev b638e90ca4e6e5a6fc4f00029d62f8e064aa18eb
  • SPVGEN: dev 6c2f36bcf0f8ff7ba8d20c8b789ca6346d1e16b1
  • XGL: dev 89a4cf115b9a2972ff00e2fe4959f4f1c8e7175b
  • LLVM-PROJECT: amd-gfx-gpuopen-dev b439932ec28c68cd68daf8420cc649c18f9fe955
CTS tests (Failed: 0/199929)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 37585/66643 (56.4%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 29058/66643 (43.6%)
    • Warnings: 0/66643 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 37436/66643 (56.2%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 29207/66643 (43.8%)
    • Warnings: 0/66643 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 38645/66643 (58.0%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 27998/66643 (42.0%)
    • Warnings: 0/66643 (0.0%)

@amdvlk-admin
Copy link
Collaborator

Test summary for commit ee83e6c

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev b638e90ca4e6e5a6fc4f00029d62f8e064aa18eb
  • SPVGEN: dev 6c2f36bcf0f8ff7ba8d20c8b789ca6346d1e16b1
  • XGL: dev 89a4cf115b9a2972ff00e2fe4959f4f1c8e7175b
  • LLVM-PROJECT: amd-gfx-gpuopen-dev b439932ec28c68cd68daf8420cc649c18f9fe955
CTS tests (Failed: 0/199929)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 37585/66643 (56.4%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 29058/66643 (43.6%)
    • Warnings: 0/66643 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 37436/66643 (56.2%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 29207/66643 (43.8%)
    • Warnings: 0/66643 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 38645/66643 (58.0%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 27998/66643 (42.0%)
    • Warnings: 0/66643 (0.0%)

kuhar
kuhar reviewed Feb 9, 2022
View reviewed changes
lgc/util/PassManager.cpp Outdated Show resolved Hide resolved
Flakebi
Flakebi reviewed Feb 9, 2022
View reviewed changes
lgc/patch/Patch.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_1825023687/index.html.
Configuration: release_clang_coverage.

@github-actions
Copy link

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_1825023687/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 68bcd93

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev b638e90ca4e6e5a6fc4f00029d62f8e064aa18eb
  • SPVGEN: dev 6c2f36bcf0f8ff7ba8d20c8b789ca6346d1e16b1
  • XGL: dev 89a4cf115b9a2972ff00e2fe4959f4f1c8e7175b
  • LLVM-PROJECT: amd-gfx-gpuopen-dev b439932ec28c68cd68daf8420cc649c18f9fe955
CTS tests (Failed: 0/199929)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 37585/66643 (56.4%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 29058/66643 (43.6%)
    • Warnings: 0/66643 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 37436/66643 (56.2%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 29207/66643 (43.8%)
    • Warnings: 0/66643 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 38645/66643 (58.0%)
    • Failed: 0/66643 (0.0%)
    • Not Supported: 27998/66643 (42.0%)
    • Warnings: 0/66643 (0.0%)

@Flakebi
Copy link
Member

Flakebi commented Feb 11, 2022

Looks fine to me (though I didn’t look through all the details)

@bsaleil
Copy link
Contributor Author

bsaleil commented Feb 15, 2022

Addressed review comments

@github-actions
Copy link

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_1848923731/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@github-actions
Copy link

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_1848923731/index.html.
Configuration: release_clang_coverage.

@JaxLinAMD
Copy link
Contributor

/rebase

@kuhar
Copy link
Contributor

kuhar commented Feb 17, 2022

/rebase

FYI, rebase won't work on recent PRs because we changed one of the CI workflows. GitHub does not allow you to rebase if workflows changed between the old commit and current dev.

@JaxLinAMD
Copy link
Contributor

got it. thanks for the information!

@JaxLinAMD JaxLinAMD merged commit dbb02f5 into GPUOpen-Drivers:dev Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar left review comments

@Flakebi Flakebi Flakebi left review comments

@amdrexu amdrexu amdrexu approved these changes

@piotrAMD piotrAMD piotrAMD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bsaleil @amdvlk-admin @Flakebi @JaxLinAMD @kuhar @amdrexu @piotrAMD