Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ELF symbol type for symbols added to linker output sections #1708

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix ELF symbol type for symbols added to linker output sections #1708

merged 1 commit into from
Feb 23, 2022

Conversation

jayfoad
Copy link
Member

@jayfoad jayfoad commented Feb 22, 2022

Elf64_Sym::setType expects an ELF symbol type, but
ElfSymbolRef::getType returns a generic SymbolRef::Type.

@jayfoad
Fix ELF symbol type for symbols added to linker output sections
3946847 
Elf64_Sym::setType expects an ELF symbol type, but
ElfSymbolRef::getType returns a generic SymbolRef::Type.
@jayfoad jayfoad requested a review from a team as a code owner February 22, 2022 16:14
@jayfoad
Copy link
Member Author

jayfoad commented Feb 22, 2022

This will avoid problems when D117642 lands, which changes the internal symbol type enumeration but should not affect ELF symbol types.

@jayfoad jayfoad requested a review from trenouf February 22, 2022 16:47
@amdvlk-admin
Copy link
Collaborator

Test summary for commit 3946847

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev 2483d46fa27c30502e497ea169ee53b142e9fa06
  • SPVGEN: dev 95304f054cb80a35fb46d5de9c0f9be6e1c9f081
  • XGL: dev 1ce25b1ed8829c27645edd646a3289e4c524c84c
  • LLVM-PROJECT: amd-gfx-gpuopen-dev afe13751c21d672a992d83f7d33856958f7d2f3b
CTS tests (Failed: 1/186845)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 37627/66653 (56.5%)
    • Failed: 0/66653 (0.0%)
    • Not Supported: 29026/66653 (43.5%)
    • Warnings: 0/66653 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 33276/53539 (62.2%)
    • Failed: 1/53539 (0.0%)

      Failures:

      FAILURE: dEQP-VK.subgroups.clustered.graphics.subgroupclusteredmax_i16vec4
Stack trace: Script:
Crash

    • Not Supported: 20262/53539 (37.8%)
    • Warnings: 0/53539 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 38685/66653 (58.0%)
    • Failed: 0/66653 (0.0%)
    • Not Supported: 27968/66653 (42.0%)
    • Warnings: 0/66653 (0.0%)

@jayfoad
Copy link
Member Author

jayfoad commented Feb 23, 2022

retest this please

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 3946847

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev 2483d46fa27c30502e497ea169ee53b142e9fa06
  • SPVGEN: dev 95304f054cb80a35fb46d5de9c0f9be6e1c9f081
  • XGL: dev 1ce25b1ed8829c27645edd646a3289e4c524c84c
  • LLVM-PROJECT: amd-gfx-gpuopen-dev afe13751c21d672a992d83f7d33856958f7d2f3b
CTS tests (Failed: 1/152163)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 37627/66653 (56.5%)
    • Failed: 0/66653 (0.0%)
    • Not Supported: 29026/66653 (43.5%)
    • Warnings: 0/66653 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 12252/18857 (65.0%)
    • Failed: 1/18857 (0.0%)

      Failures:

      FAILURE: dEQP-VK.binding_model.buffer_device_address.set3.depth3.baseubo.convertcheckuv2.store.single.std140.frag
Stack trace: Script:
Crash

    • Not Supported: 6604/18857 (35.0%)
    • Warnings: 0/18857 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 38685/66653 (58.0%)
    • Failed: 0/66653 (0.0%)
    • Not Supported: 27968/66653 (42.0%)
    • Warnings: 0/66653 (0.0%)

@Flakebi
Copy link
Member

Flakebi commented Feb 23, 2022

retest this please

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 3946847

Driver commits used in build
  • CWPACK: amd-master 39f8940199e60c44d4211cf8165dfd12876316fa
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev 2483d46fa27c30502e497ea169ee53b142e9fa06
  • SPVGEN: dev 95304f054cb80a35fb46d5de9c0f9be6e1c9f081
  • XGL: dev 1ce25b1ed8829c27645edd646a3289e4c524c84c
  • LLVM-PROJECT: amd-gfx-gpuopen-dev afe13751c21d672a992d83f7d33856958f7d2f3b
CTS tests (Failed: 0/199959)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 37627/66653 (56.5%)
    • Failed: 0/66653 (0.0%)
    • Not Supported: 29026/66653 (43.5%)
    • Warnings: 0/66653 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 37478/66653 (56.2%)
    • Failed: 0/66653 (0.0%)
    • Not Supported: 29175/66653 (43.8%)
    • Warnings: 0/66653 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 38685/66653 (58.0%)
    • Failed: 0/66653 (0.0%)
    • Not Supported: 27968/66653 (42.0%)
    • Warnings: 0/66653 (0.0%)

@jayfoad jayfoad merged commit 80b7708 into GPUOpen-Drivers:dev Feb 23, 2022
@piotrAMD piotrAMD mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar approved these changes

@amdrexu amdrexu amdrexu approved these changes

@trenouf trenouf Awaiting requested review from trenouf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jayfoad @amdvlk-admin @Flakebi @kuhar @amdrexu