Add mesh shader support: Rename vertexIndex to vertexOrPrimitiveIndex #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the builder methods 'CreateWriteGenericOutput' and 'CreateWriteBuiltInOutput', they have a parameter 'vertexIndex' for TCS output to represent the outermost dimension as vertex indexing. Now, the two methods will be used by mesh shader. And mesh shader introduces per-primitive outputs which need this parameter and the semantics are similar. Rename it to 'vertexOrPrimitiveIndex' to accommodate this change.
|
The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_2429429773/index.html. |
|
The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_2429429773/index.html. |
linqun
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the builder methods 'CreateWriteGenericOutput' and
'CreateWriteBuiltInOutput', they have a parameter 'vertexIndex' for TCS
output to represent the outermost dimension as vertex indexing. Now, the
two methods will be used by mesh shader. And mesh shader introduces
per-primitive outputs which need this parameter and the semantics are
similar. Rename it to 'vertexOrPrimitiveIndex' to accommodate this
change.