CMakeLists: Yet another iteration on getting dynamic linking right #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit c38b3be and replaces it with a more explicit approach. There are really two key underlying issues: - lgc is treated partially as an LLVM component library but isn't linked into libLLVM-${version}.so. This is as it should be. - llvm_map_components_to_libnames is really designed to be used together with the add_llvm_{executable,library} macros which we don't use consistently. These take care of choosing between dynamic vs. static linking for LLVM. We do this manually for llpc in this change.
|
The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_2699968936/index.html. |
|
The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_2699968936/index.html. |
Test summary for commit fc5d705CTS tests (Failed: 0/216210)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8 |
Flakebi
reviewed
Jul 20, 2022
Flakebi
approved these changes
Jul 20, 2022
amdrexu
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit c38b3be
and replaces it with a more explicit approach.
There are really two key underlying issues:
into libLLVM-${version}.so. This is as it should be.
with the add_llvm_{executable,library} macros which we don't use
consistently. These take care of choosing between dynamic vs. static
linking for LLVM. We do this manually for llpc in this change.