Fail compilation when node cannot be found #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of GPUOpen-Drivers@da8ce39 compilation succeeds when the resource node cannot be found. This change restores the pre-existing behavior (set by GPUOpen-Drivers@ad73950).
Test summary for commit 88fefd5CTS tests (Failed: 0/216007)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2xRhel 8.6, Gfx10 |
An example test is here: https://github.com/GPUOpen-Drivers/llpc/blob/dev/llpc/test/shaderdb/general/AggressiveInvariantLoads.pipe |
|
Are we sure that this doesn't break mutable descriptors? IIRC there was a case of problematic design that was basically papered over by this behavior. If this is now solved properly, then great! |
Flakebi
reviewed
May 24, 2023
|
retest this please (← triggers Jenkins) |
Test summary for commit f6e7ea2CTS tests (Failed: 953/213076)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2xRhel 8.6, Gfx10 |
|
Seems like there are indeed cases where the previous behavior was desired. |
|
retest this please |
|
f6e7ea2 Jenkins build error. |
|
retest this please |
Test summary for commit f6e7ea2CTS tests (Failed: 656/141320)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
|
f6e7ea2 Jenkins build error. |
|
retest this please |
Test summary for commit 2f52239CTS tests (Failed: 0/141308)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
|
retest this please |
Test summary for commit 2f52239CTS tests (Failed: 0/140867)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of da8ce39 compilation succeeds when the resource node cannot be found. This change restores the pre-existing behavior (set by ad73950).