Set new LLVM atomic optimizer strategy option #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary for commit 736b360CTS tests (Failed: 0/141320)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2xRhel 8.6, Gfx10 |
See: https://reviews.llvm.org/D147408#4394537 The LLVM AMDGPU atomic optimizer pass has a new command line option -amdgpu-atomic-optimizer-strategy= which currently defaults to DPP, but the plan is to change the default to Iterative. Set it to DPP explicitly so that LLPC will not be affected by that change.
Test summary for commit 736b360CTS tests (Failed: 0/141320)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
Flakebi
approved these changes
Jun 9, 2023
Test summary for commit c0bd803CTS tests (Failed: 0/141320)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2xRhel 8.6, Gfx10 |
Test summary for commit c0bd803CTS tests (Failed: 0/141320)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
amdrexu
approved these changes
Jun 12, 2023
nhaehnle
approved these changes
Jun 12, 2023
pravinjagtap
pushed a commit
to llvm/llvm-project
that referenced
this pull request
Jun 15, 2023
The D147408 implemented new Iterative approach for scan computations and added new flag `amdgpu-atomic-optimizer-strategy` which is defaulted to DPP. The changeset GPUOpen-Drivers/llpc#2506 adapts to the new changes in LLPC. This patch enables atomic optimizer pass and selects Iterative approach for scan computations by default for compute pipeline. Reviewed By: foad Differential Revision: https://reviews.llvm.org/D152649
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 13, 2023
The D147408 implemented new Iterative approach for scan computations and added new flag `amdgpu-atomic-optimizer-strategy` which is defaulted to DPP. The changeset GPUOpen-Drivers/llpc#2506 adapts to the new changes in LLPC. This patch enables atomic optimizer pass and selects Iterative approach for scan computations by default for compute pipeline. Reviewed By: foad Differential Revision: https://reviews.llvm.org/D152649 Change-Id: I92916327d76535d7a4a0fa347442196732cd0237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://reviews.llvm.org/D147408#4394537
The LLVM AMDGPU atomic optimizer pass has a new command line option -amdgpu-atomic-optimizer-strategy= which currently defaults to DPP, but the plan is to change the default to Iterative. Set it to DPP explicitly so that LLPC will not be affected by that change.