Do not explicitly enable the LLVM atomic optimizer pass #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://reviews.llvm.org/D152649 The LLVM AMDGPU atomic optimizer pass is now enabled by default, and the existing option to enable or disable it will be removed in favour of setting the strategy to "None".
nhaehnle
approved these changes
Jun 15, 2023
Test summary for commit a6aca9bCTS tests (Failed: 0/141320)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://reviews.llvm.org/D152649
The LLVM AMDGPU atomic optimizer pass is now enabled by default, and the existing option to enable or disable it will be removed in favour of setting the strategy to "None".