Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change use of Constant Propagation Pass to SCCPPass. #871

Merged
merged 1 commit into from Aug 4, 2020

Conversation

perlfu
Copy link
Contributor

@perlfu perlfu commented Aug 3, 2020

Constant propagation pass has been removed in upstream LLVM in favour of focusing support on SCCP.
See https://reviews.llvm.org/D84447

@amdvlk-admin
Copy link
Collaborator

Test summary for commit d0641d6

Driver commits used in build
  • CWPACK: amd-master 7387247eb9889ddcabbc1053b9c2052e253b088e
  • METROHASH: amd-master 712f76fee75d69b23a1ea8f6465752c3ccaaf9a2
  • PAL: dev ea5db60841dab7d067f5010f28a980ef222bdf81
  • SPVGEN: dev 8dc855026f2502ab3f45dadaf0bb802a57d6ad60
  • XGL: dev 8d9da0426ba869f5f3da23fd72cfaa669ce99c25
  • LLVM-PROJECT: amd-gfx-gpuopen-dev 8abd9486af1727c8c38afcfef7390d70bb7d7d89
CTS tests (Failed: 2/42770)
  • Built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix
  • Rhel 8.2, Gfx8
    • No Results
    Ubuntu 20.04, Gfx10
    • No Results
    Ubuntu 18.04, Gfx9
    • Passed: 42768/42770 (100.0%)
    • Failed: 2/42770 (0.0%)

      Failures:

      FAILURE: dEQP-VK.glsl.swizzles.vector_swizzles.mediump_ivec4_w_fragment
      Stack trace: Flake
      
      FAILURE: dEQP-VK.renderpass.suballocation.multisample_resolve.r8g8b8a8_sint.samples_8
      Stack trace: Flake
      

@piotrAMD
Copy link
Contributor

piotrAMD commented Aug 3, 2020

LGTM (modulo missing test update in ExtShaderInt8_TestSharedVarLoadStore).
Might be good to add the reference to LLVM change in the commit message - I think that would be D84447 or 599955eb56eb.

@perlfu
Copy link
Contributor Author

perlfu commented Aug 3, 2020

LGTM (modulo missing test update in ExtShaderInt8_TestSharedVarLoadStore).
Might be good to add the reference to LLVM change in the commit message - I think that would be D84447 or 599955eb56eb.

Thanks, I will add the LLVM reference to the commit message.
I need to fix up the lit test differences.

Constant propagation pass has been removed in upstream LLVM
in favour of focusing support on SCCP.
See https://reviews.llvm.org/D84447
@dstutt
Copy link
Member

dstutt commented Aug 4, 2020

LGTM

Copy link
Member

@dstutt dstutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trenouf trenouf merged commit 34bec4b into GPUOpen-Drivers:dev Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants