Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LLVM15 #69

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Support LLVM15 #69

merged 3 commits into from
Oct 26, 2023

Conversation

vchuravy
Copy link
Contributor

Considering #68 (comment) I was trying to see
what it would take to compile llvm-dialects for LLVM 15.

Right now I am hitting

[  4%] Building CXX object CMakeFiles/llvm_dialects.dir/lib/Dialect/OpDescription.cpp.o
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:148:34: error: ‘LifetimeIntrinsic’ was not declared in this scope
  148 | HANDLE_INTRINSIC_DESC_OPCODE_SET(LifetimeIntrinsic, Intrinsic::lifetime_start,
      |                                  ^~~~~~~~~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:139:55: note: in definition of macro ‘HANDLE_INTRINSIC_DESC_OPCODE_SET’
  139 |   template <> const OpDescription &OpDescription::get<Class>() {               \
      |                                                       ^~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:139:36: error: template-id ‘get<<expression error> >’ for ‘const llvm_dialects::OpDescription& llvm_dialects::OpDescription::get()’ does not match any template declaration
  139 |   template <> const OpDescription &OpDescription::get<Class>() {               \
      |                                    ^~~~~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:148:1: note: in expansion of macro ‘HANDLE_INTRINSIC_DESC_OPCODE_SET’
  148 | HANDLE_INTRINSIC_DESC_OPCODE_SET(LifetimeIntrinsic, Intrinsic::lifetime_start,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:17:
/home/vchuravy/src/llvm-dialects/include/llvm-dialects/Dialect/OpDescription.h:66:55: note: candidate is: ‘template<class OpT> static const llvm_dialects::OpDescription& llvm_dialects::OpDescription::get()’
   66 |   template <typename OpT> static const OpDescription &get();
      |                                                       ^~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp: In static member function ‘static const llvm_dialects::OpDescription& llvm_dialects::OpDescription::get() [with OpT = llvm::DbgInfoIntrinsic]’:
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:154:45: error: ‘dbg_assign’ is not a member of ‘llvm::Intrinsic’
  154 |                                  Intrinsic::dbg_assign)
      |                                             ^~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:140:34: note: in definition of macro ‘HANDLE_INTRINSIC_DESC_OPCODE_SET’
  140 |     static unsigned opcodes[] = {__VA_ARGS__};                                 \
      |                                  ^~~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp: In static member function ‘static const llvm_dialects::OpDescription& llvm_dialects::OpDescription::get() [with OpT = llvm::DbgVariableIntrinsic]’:
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:158:67: error: ‘dbg_assign’ is not a member of ‘llvm::Intrinsic’
  158 |                                  Intrinsic::dbg_value, Intrinsic::dbg_assign)
      |                                                                   ^~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:140:34: note: in definition of macro ‘HANDLE_INTRINSIC_DESC_OPCODE_SET’
  140 |     static unsigned opcodes[] = {__VA_ARGS__};                                 \
      |                                  ^~~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp: At global scope:
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:166:23: error: ‘DbgAssignIntrinsic’ was not declared in this scope
  166 | HANDLE_INTRINSIC_DESC(DbgAssignIntrinsic, dbg_assign)
      |                       ^~~~~~~~~~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:134:55: note: in definition of macro ‘HANDLE_INTRINSIC_DESC’
  134 |   template <> const OpDescription &OpDescription::get<Class>() {               \
      |                                                       ^~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:134:36: error: template-id ‘get<<expression error> >’ for ‘const llvm_dialects::OpDescription& llvm_dialects::OpDescription::get()’ does not match any template declaration
  134 |   template <> const OpDescription &OpDescription::get<Class>() {               \
      |                                    ^~~~~~~~~~~~~
/home/vchuravy/src/llvm-dialects/lib/Dialect/OpDescription.cpp:166:1: note: in expansion of macro ‘HANDLE_INTRINSIC_DESC’
  166 | HANDLE_INTRINSIC_DESC(DbgAssignIntrinsic, dbg_assign)
      | ^~~~~~~~~~~~~~~~~~~~~
/home/vchuravy/src/llvm-dialects/include/llvm-dialects/Dialect/OpDescription.h:66:55: note: candidate is: ‘template<class OpT> static const llvm_dialects::OpDescription& llvm_dialects::OpDescription::get()’
   66 |   template <typename OpT> static const OpDescription &get();
      |                                                       ^~~
make[2]: *** [CMakeFiles/llvm_dialects.dir/build.make:118: CMakeFiles/llvm_dialects.dir/lib/Dialect/OpDescription.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:259: CMakeFiles/llvm_dialects.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

@vchuravy vchuravy marked this pull request as ready for review October 25, 2023 20:43
@vchuravy
Copy link
Contributor Author

@nhaehnle I can setup CI against the LLVM builds that Julia uses if that would be helpful.

Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@nhaehnle
Copy link
Member

@nhaehnle I can setup CI against the LLVM builds that Julia uses if that would be helpful.

Sure!

@nhaehnle nhaehnle merged commit f00b575 into GPUOpen-Drivers:dev Oct 26, 2023
8 checks passed
@vchuravy vchuravy deleted the vc/compat_llvm15 branch October 26, 2023 12:53
@vchuravy
Copy link
Contributor Author

Ah shoot TargetExtType needs LLVM 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants