rdf: Include cstdint header explicitly for std::int64_t and friends
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
rdf-cstdint-gcc-13
branch
2 times, most recently
from
27840c7
to
935599d
Compare
Flakebi
previously approved these changes
May 23, 2023
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
May 24, 2023
MarijnS95
force-pushed
the
rdf-cstdint-gcc-13
branch
from
935599d
to
3252a38
Compare
On gcc-13 these integer types appear to no longer be included via
`(c)string` or other `std` headers (according to a [similar fix]),
resulting in many of the following compiler errors in `amdrdf.{cpp,h}`:
In file included from pal/src/core/imported/rdf/rdf/src/amdrdf.cpp:25:
pal/src/core/imported/rdf/rdf/inc/amdrdf.h:112:39: error: ‘int64_t’ in namespace ‘std’ does not name a type
112 | int (*Read)(void* ctx, const std::int64_t count, void* buffer, std::int64_t* bytesRead);
| ^~~~~~~
Solve this by including `cstdint` explicitly.
[similar fix]: google/breakpad@7ea7ded
MarijnS95
force-pushed
the
rdf-cstdint-gcc-13
branch
from
3252a38
to
56868b7
Compare
|
retest this please |
|
@jinjianrong what needs to be retested? This repository hasn't changed since this PR was last updated, and it is still required to solve the build error. |
|
@MarijnS95 This is to tell our internal jenkins to run pre-submission build and tests for the PR, not to you. Sorry for the confusion. |
|
Can one of the admins verify this patch? |
Test summary for commit 56868b7CTS tests (Failed: 0/213062)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
1 similar comment
Test summary for commit 56868b7CTS tests (Failed: 0/213062)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
|
Ah that is cool, thank you for explaining @jinjianrong! (Perhaps if the wording includes |
|
This is fixed internally, but it will take a while to trickle through the release branches. I’ll see if we can get this into one of the next releases. |
jinjianrong
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gcc-13 these integer types appear to no longer be included via
(c)stringor otherstdheaders (according to a similar fix), resulting in many of the following compiler errors inamdrdf.{cpp,h}:Solve this by including
cstdintexplicitly.