Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPA is not library friendly #36

Open
chaoticbob opened this issue Mar 3, 2019 · 2 comments
Open

GPA is not library friendly #36

chaoticbob opened this issue Mar 3, 2019 · 2 comments

Comments

@chaoticbob
Copy link

GPA usage of CMake is very awkward making it difficult to simply include GPA into an existing large project by setting variables and then calling add_subdirectory. Currently doing so causes the build process to produce binary paths that can't be found.
@chesik-amd
Copy link
Collaborator

Yes, this isn't a usage model that we considered. We'll take a look to see what can be done to make this experience better.

chesik-amd added a commit that referenced this issue Mar 18, 2019
@chesik-amd
Update CMake files
113b0be 
* use current source dir to allow other projects to easily integrate
GPA's build

This should address the issue mentioned here: #36
@chesik-amd
Copy link
Collaborator

I've just pushed a few changes to the CMake files. WIth these changes, we've been able to include GPA in another project by simply using add_subdirectory. There is still a prerequisite that you'll need to run UpdateCommon.py before doing this. Can you give the latest sources a try and see if it works better for you? If you still run into problems, we may need more info on exactly how you are using this, and what exact problems you still see.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaoticbob @chesik-amd