-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequential calls to predict using VFE and SVGP models #1030
Comments
@tadejkrivec sorry for the late answer, I believe it's because of the lack of storing the pre-computed matrices -- the SGPR model in predict_y still operates on the 70000-row X and Y vectors (computing exactly) each time, whereas SVGP has stored that information ("approximately") in the q(u) distribution which is much smaller. "Time complexity" just means whether it's O(NM^2 + M^3), doesn't say anything about the prefactor... Really, this would be long better on stackoverflow.com (tag gpflow: https://stackoverflow.com/questions/tagged/gpflow), if you would be up for posting your question again there I'll add my answer there and future users can come across it too. Thanks! |
I've posted the question on Stackoverflow. I did figure that on my own. My workaround is a custom implementation for prediction where I precompute the part of the graph dependent on the training dataset and then reuse it in a loop. |
Feel free to answer it yourself then! :)
…On Wed, 4 Dec 2019 at 08:05, tadejkrivec ***@***.***> wrote:
I've posted the question on Stackoverflow. I did figure that on my own. My
workaround is a custom implementation for prediction where I precompute the
part of the graph dependent on the training dataset and then reuse it in a
loop.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1030?email_source=notifications&email_token=ABL7FD3Y24KKYUOXDREKAFTQW5QEVA5CNFSM4IOGGKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4C64A#issuecomment-561524592>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL7FD2USRYG4EJQX4AYFITQW5QEVANCNFSM4IOGGKYA>
.
|
I already posted this under another issue. I have an example where I have to call predict sequentially. Why would SVGP predictions be faster then SGPR in that case? Isn't the time complexity with prediction the same for all sparse models or am I missing something? This is the code I ran for testing it:
The text was updated successfully, but these errors were encountered: