fix broken API docs #1587
Merged
fix broken API docs #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Codecov Report
@@ Coverage Diff @@
## develop #1587 +/- ##
========================================
Coverage 95.13% 95.13%
========================================
Files 86 86
Lines 3845 3845
========================================
Hits 3658 3658
Misses 187 187
Continue to review full report at Codecov.
|
insysion
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent PR for compatibility with multiple tfp versions (#1553, updated by #1574) broke our Sphinx build: we set
autodoc_mock_imports = ["tensorflow", "tensorflow_probability"]in doc/source/conf.py; this means when building the documentation,tfpis a mock, andtfp.__version__cannot be parsed andVersion(tfp.__version__)errors! This PR moves the version checks insidereset_cache_bijectors, so there won't be an import-time error anymore (and Sphinx does not actually execute the code).A few minor fly-by changes that I uncovered in preparing this PR...