Proposed fix for the fully_correlated_conditional_repeat issue #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1652 +/- ##
===========================================
+ Coverage 96.17% 96.35% +0.18%
===========================================
Files 86 86
Lines 3867 3868 +1
===========================================
+ Hits 3719 3727 +8
+ Misses 148 141 -7
Continue to review full report at Codecov.
|
st--
reviewed
Apr 1, 2021
Comment on lines
327
to
334
| @pytest.fixture(name="full_cov", params=[True, False]) | ||
| def _full_cov_fixture(request): | ||
| return request.param | ||
|
|
||
|
|
||
| @pytest.fixture(name="full_output_cov", params=[True, False]) | ||
| def _full_output_cov_fixture(request): | ||
| return request.param |
There was a problem hiding this comment.
In another PR I saw this moved into a conftest.py - do you want to do that here already ?
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #1651.
I have expanded the unit test cases for the
fully_correlated_conditional_repeatandfully_correlated_conditionalto cover the problematic parameter combinations.