Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prod tf version to 2.11 #2110

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Update prod tf version to 2.11 #2110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
070df90
Update prod tf version to 2.11
May 16, 2024
d1878b8
Handle matplotlib deprecation
Jun 12, 2024
a508582
Try making mypy happy
Jun 12, 2024
1c396ae
And again
Jun 12, 2024
2d1d00d
etc
Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ parameters:
default: "2.4.0"
prod_tf_ver:
type: string
default: "2.8.4"
default: "2.11.1"
max_tf_ver:
type: string
default: "2.16.1"
Expand All @@ -24,7 +24,7 @@ parameters:
default: "0.12.0"
prod_tfp_ver:
type: string
default: "0.16.0"
default: "0.19.0"
max_tfp_ver:
type: string
default: "0.24.0"
Expand Down
7 changes: 5 additions & 2 deletions benchmark/plotters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@
from math import isnan
from typing import Collection, Tuple

import matplotlib
import pandas as pd
from matplotlib.axes import Axes
from matplotlib.dates import date2num
from packaging.version import Version

from benchmark.grouping import GroupingKey, GroupingSpec, group
from benchmark.metadata import BenchmarkMetadata, parse_timestamp
Expand Down Expand Up @@ -85,8 +87,9 @@ def metrics_box_plot(
for key, df, _ in group(metrics_df, [], metadata, line_by):
labels.append(_join_key(key))
values.append(df.value)
ax.boxplot(values, labels=labels)

# cf https://github.com/matplotlib/matplotlib/pull/27901
label_id = "tick_labels" if Version(matplotlib.__version__) >= Version("3.9.0") else "labels"
ax.boxplot(values, **{label_id: labels}) # type: ignore[arg-type]
_shared_ax_config(ax, file_key, column_key, row_key, metric)


Expand Down