Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move download tools dependency #203

Merged
merged 22 commits into from
Jul 10, 2023
Merged

Conversation

GameSetAndMatch
Copy link
Collaborator

This PR fixe issue #{issue number}

download tools were in the CLI, made a lot of unwanted dependencies between the module's packages Moved the download tools in its own directory

Add images if possible

davebulaval
davebulaval previously approved these changes Jul 10, 2023
Copy link
Collaborator

@davebulaval davebulaval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes before approval.

deepparse/cli/parser_arguments_adder.py Outdated Show resolved Hide resolved
deepparse/download_tools.py Show resolved Hide resolved
deepparse/download_tools.py Outdated Show resolved Hide resolved
deepparse/download_tools.py Outdated Show resolved Hide resolved
deepparse/download_tools.py Outdated Show resolved Hide resolved
deepparse/download_tools.py Show resolved Hide resolved
deepparse/download_tools.py Outdated Show resolved Hide resolved
deepparse/download_tools.py Show resolved Hide resolved
deepparse/network/seq2seq.py Outdated Show resolved Hide resolved
deepparse/parser/address_parser.py Outdated Show resolved Hide resolved
davebulaval
davebulaval previously approved these changes Jul 10, 2023
deepparse/download_tools.py Show resolved Hide resolved
@davebulaval davebulaval merged commit 7ac8c93 into dev Jul 10, 2023
40 checks passed
@davebulaval davebulaval deleted the move-download-tools-dependency branch July 10, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants