okapi: fix deserialisation for openapi3 'extensions' fields #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'extensions' fields of various structs within okapi/src/openapi3.rs was not deserialized correctly. This commit fixes the behavior if the Object is an indexmap. Using rocket_okapi enables the feature 'preserve_order' by default and hence an indexmap is used. If the feature 'preserve_order' is disables, this commit should not change the behavior. Belongs to GREsau#67 Signed-off-by: Philippe Schaaf <philippe.schaaf@secunet.com>
|
IndexMap has a custom serde function: https://docs.rs/indexmap/latest/indexmap/serde_seq/index.html |
|
@GREsau does it make sens to you to provide a serde_seq module via the schemars crate depending on the cfg feature? IMO this would be a cleaner way of achieving the desired de-/serialization in a feature-aware way and importing the indexmap crate would not be needed any longer. My suggestion: GREsau/schemars#161 |
|
So the problem is that the |
Signed-off-by: Simon Bechstedt <simon.bechstedt@secunet.com>
Use patched version until PR GREsau/schemars#161 is merged. Signed-off-by: Simon Bechstedt <simon.bechstedt@secunet.com>
SBechstedt
force-pushed
the
fix-indexmap-serde
branch
from
084a824
to
0237c8a
Compare
Signed-off-by: Simon Bechstedt <simon.bechstedt@secunet.com>
…fix-indexmap-serde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'extensions' fields of various structs
within okapi/src/openapi3.rs was not
deserialized correctly.
#[serde(flatten)]was empty.
The 'extensions' fields used a custom type 'Object'.
'Object' is an alias for IndexMap or BTreeMap depending
on feature 'preserve_order'. Deserialisation should work for both.
Using rocket_okapi enables the feature 'preserve_order'
by default.
Belongs to #67