Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[schemars(inner(...)] attribute to specify schema for array items #234

Merged
merged 4 commits into from
Sep 9, 2023
Merged

Add #[schemars(inner(...)] attribute to specify schema for array items #234

merged 4 commits into from
Sep 9, 2023

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Jul 30, 2023

Resolves #110

@jirutka jirutka changed the title Add #[schemars(inner(...)] attribute Add #[schemars(inner(...)] attribute to specify schema for array items Jul 30, 2023
@jirutka
Copy link
Contributor Author

jirutka commented Jul 30, 2023

CI / ci (1.45.0) (pull_request) Failing after 42s

This is unrelated to the changes made in this PR.

@jirutka
Copy link
Contributor Author

jirutka commented Aug 6, 2023

@GREsau, can you please look at this PR?

@jirutka
Fix test validate_schemars_attrs to actually use Struct2
ae13a46 
It currently validates the struct with the `validate` attributes instead
of the one with the schemars attributes. Probably a typo.
@jirutka
Add #[schemars(inner(...)] attribute
6639b52 
To specify schema for array items.

Resolves #110
@jirutka
Refactor get_meta_items()
6c715ad
@jirutka
Copy link
Contributor Author

jirutka commented Aug 29, 2023

@GREsau 🙏

@GREsau
Copy link
Owner

GREsau commented Aug 30, 2023

At first glance this looks good - I'm planning on getting through another batch of PRs/issues this weekend, so I should be able to take a closer look then 🙂

@GREsau GREsau merged commit a5e51b2 into GREsau:master Sep 9, 2023
4 checks passed
@GREsau
Copy link
Owner

GREsau commented Sep 9, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GREsau GREsau GREsau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set regex for Array String items
2 participants
@jirutka @GREsau