Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access deletion ADR #3897

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Add access deletion ADR #3897

merged 2 commits into from
Jun 7, 2024

Conversation

tadhg-ohiggins
Copy link
Contributor

Sometimes people leave
Sometimes people get kicked out
Either way: bye-bye.


Add Architecture Decision Record for adding ability to remove Audit Editor roles from submissions.

See #3881 for earlier discussion.

@jadudm
Copy link
Contributor

jadudm commented May 29, 2024

Only one comment:

It looks like there are two "Story 2" entries? (I'm reading the merge, so perhaps I'm confusing myself.)

I would suggest removing story 3. It speaks to what we won't do, suggesting features we don't have and aren't discussing (adding users out-of-band). I think it can safely be removed, because the list of features we aren't discussing in this ADR is infinite. Story 1 and Story 2 capture what we're doing: providing the ability for people to remove Editors, and they can't remove themselves.

Unless I'm still missing why that story is critical for scoping the feature/decision.

@tadhg-ohiggins
Copy link
Contributor Author

@jadudm agreed, that was more of an exploratory segment and doesn't need to be in the ADR; removed.

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadudm jadudm added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 4373046 Jun 7, 2024
@jadudm jadudm deleted the tadhg/adr-access-deletion-2024-05 branch June 7, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants