-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for exception page titles #139
Conversation
I appreciate what this is for, but my immediate reaction is a 👎. We don't want to be in the business of manually maintaining how the Top 20 listings look. We've made a few URL exceptions for mainstays of the Top 20, but I'd also be against adding many more URL exceptions there too. And the only reason I think we're comfortable doing even those is that URL structure is much harder to change than a |
While I agree with @konklone that it would be nice to not have to clean these up, I also think that it will provide a nicer user experience to accept this edit and do a bit of manual labor on sites that are persistently in the top 20. I find both arguments compelling, so I don't think this is clear cut and would like others to weigh in. cc @leahbannon @gbinal |
I think the move is to do this with a light touch, for a few that - like people have said - are reliably in the top 20. We don't take ensuring this for the top 20 and we do use channel pressure like @konklone says but we allow ourselves to ameliorate this some. |
In that case, we don't have to do anything. Nothing is reliably in the Top 20 that suffers from this problem. :) Let's move on, and deal it with reactively if it becomes an issue. |
I think we should reconsider this PR, for the specific case of the National Weather Service. This is consistently on the Top 20, and very confusing since both links go to the same place. |
@cew821 Can you suggest what the different titles should be for the two weather domains? We're currently mapping |
Users are viewing a forecast for a specific region, i.e. http://forecast.weather.gov/MapClick.php?x=165&y=52&site=pbz&zmx=1&zmy=1&map_x=165&map_y=52#.VQmg59X6ePU So how about "National Weather Service - Forecasts by Region" |
We could also map the URL to "forecast.weather.gov" which I realize just redirects to Weather.gov, but at least it would be a different behavior than the first link. |
👍 on both counts. |
Fixed in f72b9ed. |
Currently exceptions override page urls or domains but not page titles. This adds the option to set an exception object that specifies both a
page
andpage_title
. It's implemented on the weather map to avoid matching items:Before
After
Since these pages don't have a unique title, I borrowed from the link's
title
.Also adds missing title attribute to links for the realtime list.