SRCH-2152 Update to Rails 6.1 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SRCH-2212 Upgrade ASIS Rails 5.2 to 6.0 Ran `bundle update rails` rails 5.2.4.4 -> 5.2.6 * Bumped Rails defaults from 5.1 to 5.2 * Ran `bundle exec rails app:update` and merged changes. * Bumped Rails 5.2.6 -> 6.0.3.7 Also had to update newrelic_apm 4.2.0.334 -> 7.0.0 airbrake 7.1.1 -> 11.0.3 * Subsequent investigation reveals that we don't want to take newrelic_apm all the way to 7; newrelic recommends 6.15 as the stable version. To be handled in ticket SRCH-2170 * Ran `bundle exec rails app:update` and merged changes. * Bumped rails defaults to 6.0 Had to turn off zeitwerk. SRCH-2185 is the ticket to turn it back on. * Code review comments.
Updated directory structure, module names, and eager load paths to accomodate zeitwerk's preferences.
|
Note: this needs to go out in tandem with https://github.com/GSA/usasearch-cookbooks/pull/531 |
SRCH-2186 Ripped out all traces of airbrake and ran `bundle update`
SRCH-2214 Bumped Rails to 6.1 and ran `bundle update`
MothOnMars
commented
Aug 24, 2021
There was a problem hiding this comment.
LGTM, pending CircleCi. I created this PR, so Github won't let me approve it. @jmax-fearless , feel free to approve once it passes CI.
jmax-fearless
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Approving for @MothOnMars (since she originally opened the PR, it won't let her approve it) per our conversation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRCH-2152 Update to Rails 6.1