This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
CKAN + S3 + Openssl + NOT(FIPS) = Happy Family #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickumia-reisys
changed the title
nickumia-reisys
changed the title
- Isolate everything - No other requirement installs - No other plugins enabled in ckan - No other extends from the plugin class - Just a simple s3 upload function - Also, I believe that the only change that mattered was the custom hash function - Will update in future commits - HOWEVER, this was the first working case
S3 Test command still works! It's a miracle. There's no other conflicts with everything else just added in :)
- To write the local test, the endpoint_url was needed (as @robert-bryson has mentioned in the past) - Good news! It still works on cloud.gov with endpoint_url - Add local test validating that the file is uploaded and has the right data. - Obviously, we can't write the local test for a cloud.gov s3 service, but I tested it manually and the PR has instructions on how to test it IF YOU DON'T BELIEVE ME haha..
Hopefully, 'make up' will fix the problem. It seems like the localstack-container just isn't up for the test to talk to, hopefully that's all. It works locally, I'm not lying!
Yes, you heard me right Github Actions >:(
nickumia-reisys
force-pushed
the
S3-WORKS
branch
from
eab32b2
to
b01d385
Compare
|
Rebased onto |
robert-bryson
approved these changes
Oct 10, 2022
This was referenced Oct 11, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Setup
Grab the S3 Bucket from catalog (development):
Edit the S3 Values in
.env:Only enable theDos3testplugin,make upand run the commanddocker-compose exec app ckan datagovs3 s3-testThe file at https://s3-us-gov-west-1.amazonaws.com/cg-4392b3a2-9692-45be-8e19-b1608b93778b/test.txt should have the timestamp of when you ran the program.
References/Notes:
VirtualAddressing StyleTHE GOLDEN ANSWER