Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Catch a few Bad JSON things... #251

Merged
merged 7 commits into from
Mar 23, 2023
Merged

Catch a few Bad JSON things... #251

merged 7 commits into from
Mar 23, 2023

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys commented Mar 23, 2023

Related to

Changes:

  • Add more pre-processing steps
    • Remove trailing decimal points
    • Remove leading zeros
  • Update documentation to note that more conditions may be added in the near future

References:

@nickumia-reisys nickumia-reisys requested a review from a team March 23, 2023 15:17
@nickumia-reisys nickumia-reisys marked this pull request as draft March 23, 2023 15:19
@nickumia-reisys nickumia-reisys changed the title Remove trailing decimals from json Catch a few Bad JSON things... Mar 23, 2023
@nickumia-reisys nickumia-reisys marked this pull request as ready for review March 23, 2023 15:31
@nickumia-reisys
Copy link
Contributor Author

Those were all of the error types that I could find. I don't see a way of catching all types of this error, but I think it won't take long to iterate through them all. It just doesn't safeguard us from future errors.

@nickumia-reisys
Copy link
Contributor Author

image

Reference:

@nickumia-reisys nickumia-reisys merged commit 8147313 into main Mar 23, 2023
@nickumia-reisys nickumia-reisys deleted the trailing-decimal branch March 23, 2023 19:10
nickumia-reisys added a commit to GSA/catalog.data.gov that referenced this pull request Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants