Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

changed page size to 10k #257

Merged
merged 3 commits into from
Jun 15, 2023
Merged

changed page size to 10k #257

merged 3 commits into from
Jun 15, 2023

Conversation

robert-bryson
Copy link
Contributor

Bumping sitemap page size count from 1k to 10k to hopefully help Google Search Console along.

@nickumia-reisys
Copy link
Contributor

Does this really need a new release? Can't we just specify it as a command-line argument?

@click.option("--page_size", default=PAGE_SIZE, type=click.INT)

@btylerburton
Copy link
Contributor

bump comment by @nickumia-reisys

@robert-bryson
Copy link
Contributor Author

I think it makes sense to change the default here, given @dlennox24 's experience with sitemaps on other sites. Having a more sane default in the same place is more straight forward. This PR had two purposes: changing the default and helping walk Dan through the moving parts of our codebase.

Yes, @nickumia-reisys you are correct that we can change via the argument as well. I'm not going to fight you on this.

Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i approve a new saner default, even if we don't technically NEED to release to achieve what we want.

@robert-bryson robert-bryson merged commit e1a36d8 into main Jun 15, 2023
4 checks passed
@robert-bryson robert-bryson deleted the bump-sitemap-count branch June 15, 2023 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants