Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Refactor sitemap generation code #264

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Refactor sitemap generation code #264

merged 10 commits into from
Jul 27, 2023

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys commented Jul 24, 2023

Related to

Changes:

  • Add more common code to Sitemap class
  • Extend Sitemap class to SitemapIndex and SitemapData for better abstraction
  • Delete each sitemap object + temporary files explicitly after upload

@nickumia-reisys nickumia-reisys requested a review from a team July 27, 2023 19:19
@nickumia-reisys nickumia-reisys marked this pull request as ready for review July 27, 2023 19:19
@FuhuXia FuhuXia merged commit 57ddf60 into main Jul 27, 2023
3 checks passed
@FuhuXia FuhuXia deleted the optimize-sitemap branch July 27, 2023 19:40
nickumia-reisys added a commit to GSA/catalog.data.gov that referenced this pull request Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants