This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were using an old LTS version of Node. Once Cloud.gov started supporting the newer LTS version (LTS/carbon - v8.9.3) it only made sense to update our version of Node and NPM.
This also let us update node modules that were outdated and flagged by Gemnasium.
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
The main motivation is to resolve the security vulnerabilities and warnings pointed out by Gemnasium. Many of the node modules versions where behind a number of releases.
Another main motivation was the added support in Cloud.gov for a more recent Node LTS (lts/carbon - 8.9.3). This gives us access to NPM 5, which code-gov-web is using.
Test plan (required)
All test are passing in CircleCI
Closing issues
Fixes #151