Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

feat(CSS): add webpack plugin to inline critical path CSS #141

Merged
merged 1 commit into from Nov 7, 2016

Conversation

jeffbcross
Copy link
Contributor

The plugin uses @addyosmani's critical library to inline CSS
needed for the critical render path. Then the complete stylesheets
are loaded asynchronously, not blocking rendering.

@jbjonesjr
Copy link

@jeffbcross do you have any statistics on load time before and after the use of this plugin?

@jeffbcross
Copy link
Contributor Author

Local timelines with simulated Regular 3G showed the first paint time down from about 1600ms to 230ms. This is just one of many optimizations to make.

@jbjonesjr
Copy link

@jeffbcross you are awesome. Thanks for sharing those raw numbers. Also 👍 to @addyosmani for such an awesome plugin. Since Google is so well experienced with Angular, any other suggestions you would add?

@jeffbcross
Copy link
Contributor Author

any other suggestions you would add?

Yeah, @robwormald is working on some optimizations like ahead-of-time compilation and code splitting. I'm going to work on adding build-time prerendering for the site. There are a few other quick wins @samsaccone mentioned in #129.

@lukad03
Copy link
Contributor

lukad03 commented Nov 7, 2016

@jeffbcross can you resolve the conflicts in package.json? I merged in some PRs today that updated some of the packages in there. Once that's done I'll merge this in.

@jeffbcross
Copy link
Contributor Author

Will do!

On Monday, November 7, 2016, Luke Keller notifications@github.com wrote:

@jeffbcross https://github.com/jeffbcross can you resolve the conflicts
in package.json? I merged in some PRs today that updated some of the
packages in there. Once that's done I'll merge this in.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#141 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcTV6ZxadhDWZW9RUm5v31PHlmDUWJAks5q70VygaJpZM4KqIY4
.

Jeff Cross | Software Engineer | crossj@google.com

The plugin uses @addyosmani's critical library to inline CSS
needed for the critical render path. Then the complete stylesheets
are loaded asynchronously, not blocking rendering.
@jeffbcross
Copy link
Contributor Author

@lukad03 rebased!

@lukad03 lukad03 merged commit 08470d6 into GSA:master Nov 7, 2016
BalajiJBcs pushed a commit to BalajiJBcs/code-gov-web that referenced this pull request Jan 3, 2018
feat(CSS): add webpack plugin to inline critical path CSS
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants