Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

fix: removed 2 old and one renamed tslint rule (issue #146) #148

Merged
merged 2 commits into from Nov 7, 2016

Conversation

cdoremus
Copy link
Contributor

@cdoremus cdoremus commented Nov 5, 2016

The 'npm test' run was failing due to linting rules problem that I detailed in issue #146 . This PR fixes that issue and allows 'npm test' to run without failure.

@cdoremus
Copy link
Contributor Author

cdoremus commented Nov 6, 2016

I removed the no-parameter-properties that was causing the CircleCi build to fail and pushed it to my forked repo. I didn't realize that the fix made it into this PR, so I created PR #150 as an alternative. Feel free to close this PR or #150. Sorry for the duplication.

@cdoremus
Copy link
Contributor Author

cdoremus commented Nov 6, 2016

I closed PR #150 to avoid confusion as it is a duplicate of this PR.

@cdoremus cdoremus changed the title fix: removed 2 tslint rules and renamed one (issue #146) fix: removed 2 old and one renamed tslint rule (issue #146) Nov 6, 2016
@lukad03 lukad03 merged commit a76ac6b into GSA:master Nov 7, 2016
@cdoremus cdoremus deleted the fix/tslintrules branch November 7, 2016 20:27
BalajiJBcs pushed a commit to BalajiJBcs/code-gov-web that referenced this pull request Jan 3, 2018
Updates tslint rules to fix linting issues.

* Remove 2 rules and renamed one
* Remove no-parameter-properties
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants