Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

fix: null or undefined truncate value (issue #162) #166

Merged
merged 2 commits into from Nov 8, 2016
Merged

fix: null or undefined truncate value (issue #162) #166

merged 2 commits into from Nov 8, 2016

Conversation

cdoremus
Copy link
Contributor

@cdoremus cdoremus commented Nov 7, 2016

Fix for null or undefined values to truncate defined in issue #162. Tests for this fix are included in truncate.pipe.spec.ts. Also cleaned up linting errors in the spec file.

@lukad03 lukad03 merged commit 3858a7c into GSA:master Nov 8, 2016
@lukad03 lukad03 mentioned this pull request Nov 8, 2016
Closed
@cdoremus cdoremus deleted the fix/null-or-undefined-truncate-value branch November 13, 2016 01:53
BalajiJBcs pushed a commit to BalajiJBcs/code-gov-web that referenced this pull request Jan 3, 2018
@cdoremus @lukad03
Fix: null or undefined truncate value (issue GSA#162) (GSA#166)
9bbdead 
Fix for null or undefined values to truncate defined in issue GSA#162. Tests for this fix are included in truncate.pipe.spec.ts. Also cleaned up linting errors in the spec file.

* fix: added null check (issue GSA#162)
* Added tests for null/undefined(GSA#162). Fixed lint errors.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdoremus @lukad03