Updated help-wanted-card.template.html to show agency_id next to agency logo

[ctrimm]

Summary

This PR fixes/implements the following bugs/features

• Help Wanted page agency name missing next to agency logo #493 - Agency Name did not appear next to the agency logo on the Help Wanted Search.

This will make it a little bit easier for end users to be able to tell what Agency the Help Wanted task belongs to.

Test plan

I cloned the repo, made sure I was on the proper node version (6.11.0 at time of PR according to .nvmrc), installed the node_modules, and ran the development server. After that, I updated a couple lines of code with conditional angular logic to show/hide the <span class="help-wanted-agency-name"> tag if the agency_id is set on the item object that is passed into the help-wanted-card.template.html file.

I also -

• Manually tested the code on my local machine
• Ran unit tests -

Finished in 2.681 secs / 2.918 secs @ 21:38:28 GMT-0600 (MDT)

SUMMARY:
✔ 119 tests completed

=============================== Coverage summary ===============================
Statements   : 73.99% ( 711/961 )
Branches     : 29.57% ( 55/186 )
Functions    : 56.38% ( 137/243 )
Lines        : 72.77% ( 628/863 )
================================================================================

• Ran the end-to-end tests - 1 spec, 0 failures - Finished in 3.364 seconds

Below are two examples of what the UI looks like.

Code formatting

Closing issues

Fixes #493

[ctrimm]

Can we re-run this circleCI test @DanielJDufour - I do not have permissions to do so. I think this is a transient failure. I re-ran the tests locally on this branch and they all passed again...

[DanielJDufour]

Awesome! @ctrimm , I can confirm that this is an issue with the tests, not your code. Thanks so much for your help!

(I'll work on updating the tests, so we don't run into this problem again)

[DanielJDufour]

Great job!

[ctrimm]

@DanielJDufour - I see that the code is live, thanks.

However, the 'Help Wanted page agency name missing next to agency logo' item still is being returned in the help-wanted.json. Which is from from the GET request at this URL https://code.gov/assets/help-wanted.json.

[DanielJDufour]

@ctrimm, good catch! I'll fix that today!

[DanielJDufour]

@ctrimm , I just updated the Help Wanted page. Thanks again!

[ctrimm]

No problem @DanielJDufour. Thank you for the quick communication. I was in shock with how quickly this was addressed - definitely makes me want to pick up more tasks to contribute to.