Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan all the things #90

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Scan all the things #90

merged 7 commits into from
Apr 11, 2022

Conversation

mogul
Copy link
Collaborator

@mogul mogul commented Apr 7, 2022

Implements #6

@mogul mogul requested a review from a team April 7, 2022 05:26
@mogul mogul enabled auto-merge (rebase) April 7, 2022 06:11
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the tests "passed", it had errors. I would've been happily surprised if kube-bench turned up zero findings, but alas, it had other issues..

image

Do we want to fix the tests before merging this?

jbrown-xentity
jbrown-xentity previously approved these changes Apr 7, 2022
@mogul
Copy link
Collaborator Author

mogul commented Apr 9, 2022

Tests now fixed, requested another review.

@mogul mogul force-pushed the scan-all-the-things branch 2 times, most recently from d713137 to 1894566 Compare April 11, 2022 07:26
...may as well update all providers.

(Note I've tested with these versions when iterating on the terraform locally.)
These were needed back when Terraform didn't support depending on the entire module
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍚

@mogul mogul merged commit 79a9250 into main Apr 11, 2022
@mogul mogul deleted the scan-all-the-things branch April 11, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants