Skip to content

Commit

Permalink
fstringed key_name
Browse files Browse the repository at this point in the history
love me some fstrings
  • Loading branch information
robert-bryson committed Jun 1, 2023
1 parent 6426179 commit 5449a17
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions datagovharvester/extract/dcatus.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ def parse_catalog(catalog, job_info):
for idx, record in enumerate(catalog["dataset"]):
try:
record = json.dumps(record)
key_name = "{}/{}/{}/{}.json".format(
extract_feat_name, job_info["source_id"], job_info["job_id"], idx
)
key_name = f"{extract_feat_name}/{job_info['source_id']}/{job_info['job_id']}/{idx}.json"

Check failure on line 17 in datagovharvester/extract/dcatus.py

View workflow job for this annotation

GitHub Actions / Python Lint

Ruff (E501)

datagovharvester/extract/dcatus.py:17:89: E501 Line too long (101 > 88 characters)

Check failure on line 17 in datagovharvester/extract/dcatus.py

View workflow job for this annotation

GitHub Actions / Python Lint

Ruff (E501)

datagovharvester/extract/dcatus.py:17:89: E501 Line too long (101 > 88 characters)
yield create_s3_upload_data(record, key_name, content_types["json"])
except Exception as e:
pass

1 comment on commit 5449a17

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
datagovharvester
   __init__.py30100% 
datagovharvester/extract
   __init__.py1922 89%
   dcatus.py1122 82%
   utils.py1644 75%
datagovharvester/utils
   __init__.py00100% 
   json_utilities.py722 71%
   s3_utilities.py1544 73%
datagovharvester/validate
   __init__.py00100% 
   dcat_us.py240100% 
TOTAL951485% 

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 13.833s ⏱️

Please sign in to comment.