Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add email list field #87

Merged
merged 2 commits into from
Jul 1, 2024
Merged

add email list field #87

merged 2 commits into from
Jul 1, 2024

Conversation

Jin-Sun-tts
Copy link
Collaborator

Pull Request

Related to GSA/data.gov#4795

About

fixed the email list bug.
updated the login.gov CLIENT_ID for local docker.

@Jin-Sun-tts Jin-Sun-tts requested a review from a team July 1, 2024 19:34
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks to have been the problem we were seeing!

@jbrown-xentity
Copy link
Contributor

@btylerburton candidate for a UI test, as this bug seems to have derived from the UI and not from the model/processing code...

@btylerburton
Copy link
Contributor

Nice work, Jin! Glad to see this fixed.
Definitely a candidate for UI testing.

@btylerburton btylerburton merged commit a7bd918 into main Jul 1, 2024
4 checks passed
@btylerburton btylerburton deleted the fix-email-list branch July 1, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants