Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harvest_source notification_emails field #4795

Closed
2 tasks
btylerburton opened this issue Jun 13, 2024 · 2 comments
Closed
2 tasks

Fix harvest_source notification_emails field #4795

btylerburton opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
bug Software defect or bug H2.0/Harvest-Runner Harvest Source Processing for Harvesting 2.0

Comments

@btylerburton
Copy link
Contributor

When creating/editing a harvest source in datagov-harvest-admin, and entering an email into the notification_emails text area, the email is split up into individual characters.

How to reproduce

  1. Create/edit a harvest source in datagov-harvest-admin
  2. Add an email to the Notification_emails field.
  3. Click Submit/Update to save the change

Expected behavior

  1. Email(s) stored as a comma-separated list

Actual behavior

  1. Email addresses are split up as strings and saved as an array.

ex. a@a.com -> ['a', '@', 'a', '.', 'c', 'o', 'm']

Sketch

  • Create proper relationship and entity for saving emails
  • Potentially employ a separate table and join them in the form
@btylerburton btylerburton added bug Software defect or bug H2.0/Harvest-Runner Harvest Source Processing for Harvesting 2.0 labels Jun 13, 2024
@jbrown-xentity
Copy link
Contributor

@Jin-Sun-tts mentioned this is annoying, and will take on shortly.

@Jin-Sun-tts
Copy link
Contributor

Added a customized field to processed the email list, this issue is fixed here (GSA/datagov-harvester#87)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software defect or bug H2.0/Harvest-Runner Harvest Source Processing for Harvesting 2.0
Projects
Status: 🗄 Closed
Development

No branches or pull requests

3 participants