Skip to content
This repository has been archived by the owner on Aug 21, 2019. It is now read-only.

Upgrade to Rails 5.1.4 (#2) #16

Merged
merged 3 commits into from
Dec 19, 2017
Merged

Upgrade to Rails 5.1.4 (#2) #16

merged 3 commits into from
Dec 19, 2017

Conversation

nickmarden
Copy link
Contributor

  • groundwork
  • require "rails_helper" instead of "spec_helper"
  • Update cors_spec to use new Rails APIs
  • Update spec/api/* and spec/controllers/* to use new Rails APIs
  • Add config/secrets.yml
  • root route "/" will render rails welcome page if not defined. Render 404 Not found instead
  • Update README to recommend Ruby 2.3
  • Include instruction to run elasticsearch with docker

@viclim @nickmarden
Upgrade to Rails 5.1.4 (#2)
c1c7b7e 
* require "rails_helper" instead of "spec_helper"

* groundwork

* Update cors_spec to use new Rails APIs

* Update spec/api/* and spec/controllers/* to use new Rails APIs

* Add config/secrets.yml

* root route "/" will render rails welcome page if not defined. Render 404 Not found instead

* Update README to recommend Ruby 2.3

* Include instruction to run elasticsearch with docker
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c1c7b7e on RapidRiverSoftware:master into 34cef9a on GSA:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3c73973 on RapidRiverSoftware:master into 34cef9a on GSA:master.

@nickmarden nickmarden merged commit a1a61f9 into GSA:master Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickmarden @coveralls @viclim