Skip to content
This repository has been archived by the owner on Aug 21, 2019. It is now read-only.

Add circleci integration #20

Merged
merged 3 commits into from Mar 1, 2018
Merged

Add circleci integration #20

merged 3 commits into from Mar 1, 2018

Conversation

viclim
Copy link
Contributor

@viclim viclim commented Feb 28, 2018

Fix #19

Not using workflow as there's no real advantage of using it here.

Build will now fail if code coverage is less than 100%.

@coveralls
Copy link

coveralls commented Feb 28, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 37900e3 on RapidRiverSoftware:issue-19-add_circleci into 842ad36 on GSA:master.

@viclim viclim changed the title Add circleci integration [WIP] Add circleci integration Feb 28, 2018
@viclim
Copy link
Contributor Author

viclim commented Feb 28, 2018

Removing .travis.yml doesn't seems to stop travis from building this. Probably related to this https://blog.travis-ci.com/2014-03-05-repository-settings

@viclim
Copy link
Contributor Author

viclim commented Feb 28, 2018

coveralls is generating the error below in CircleCI

...
[Coveralls] Submitting to https://coveralls.io/api/v1
Coveralls encountered an exception:
RestClient::UnprocessableEntity
422 Unprocessable Entity
...
{"message":"Couldn't find a repository matching this job.","error":true}

It might be the switch from Travis CI to CircleCI that trip coveralls up.

@viclim
Copy link
Contributor Author

viclim commented Feb 28, 2018

The circleci badge is showing failing in https://github.com/RapidRiverSoftware/jobs_api/tree/issue-19-add_circleci. That's because the badge is showing the build status for master branch, and there's no build in circleci for the master branch.

@nickmarden
Copy link
Contributor

Repush please @viclim? I've disabled Travis CI.

@nickmarden nickmarden changed the title [WIP] Add circleci integration Add circleci integration Mar 1, 2018
@nickmarden nickmarden merged commit 9a3a50f into GSA:master Mar 1, 2018
@nickmarden nickmarden deleted the issue-19-add_circleci branch March 1, 2018 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants