Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and Display Summary on the Preview page #1169 #1184

Merged
merged 23 commits into from
Mar 11, 2024

Conversation

heyitsmebev
Copy link

@heyitsmebev heyitsmebev commented Feb 2, 2024

The purpose of this PR is allow the user to schedule a delivery and to preview the message before sending.

As a recap, there are two pages called preview that has been created in order to display specific details of a message. In addition, the old "preview" pages have now been converted into a more general schedule page where the user can select delivery time.

This discussion here can help understand how the pages should look: #815 (comment)
On the preview page for batch jobs, user should be able to see the following:

  • Preview list (csv table) with disclaimer caption: "Note: Only the first 5 rows are displayed here."
  • SMS Preview Message (message details at the top)
    • File name csv
    • Template name
    • Scheduled: Now or timestamp depending on user's actions
  • Preview of the message
  • User should see either a "Send" button or "Schedule" button depending user's actions
  • User should be able to use back link to go to previous page
  • Show Recipients list header and csv file title

On the preview page for one-off jobs, user should be able to see the following:

  • SMS Preview Message (message details at the top)
    • Template name
    • Scheduled: Now or timestamp depending on user's actions
  • Preview of the message
  • User should see either a "Send" button or "Schedule" button depending user's actions

On the schedule page, user should be able to see:

  • Select delivery time title
  • Scheduling form
  • "Preview" button

Screenshots from Figma and understanding the flow: https://www.figma.com/file/aAWhlPzOP6kfVFnCCAfSZZ/notify.gov?type=design&node-id=2020-3624&mode=design&t=D1nRLZLNSXonIYCN-0

This image is to help provide an idea of what the preview page will look like when a user sends a batch message.
image

@heyitsmebev heyitsmebev linked an issue Feb 2, 2024 that may be closed by this pull request
7 tasks
@heyitsmebev heyitsmebev marked this pull request as draft February 2, 2024 22:54
@heyitsmebev heyitsmebev marked this pull request as ready for review February 13, 2024 22:13
@heyitsmebev heyitsmebev requested review from a team and ccostino February 13, 2024 22:13
@heyitsmebev heyitsmebev marked this pull request as ready for review February 17, 2024 02:06
@ccostino
Copy link
Contributor

ccostino commented Mar 4, 2024

@heyitsmebev just noting here as a follow-up from the last discussion we had that the message parts calculations during the sending preview were not needed for this, so it should be ready for full review as it is!

Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple minor comments.

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @heyitsmebev!

All looks good to me, but I wanted to check on one thing with the preview form and the adjustment with the CSRF (cross-site request forgery) piece that is removed from it. I want to be clear on that change and why it's no longer needed, or adjust if it does have to go back in.

Thanks!

app/templates/views/check/ok.html Show resolved Hide resolved
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heyitsmebev! 🎉

@ccostino ccostino merged commit b489f49 into main Mar 11, 2024
8 checks passed
@ccostino ccostino deleted the 1169-display-confirmation-summary-on-the-preview-page branch March 11, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create and Display Summary on the Preview page
3 participants