-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and Display Summary on the Preview page #1169 #1184
Create and Display Summary on the Preview page #1169 #1184
Conversation
…tion-summary-on-the-preview-page
…tion-summary-on-the-preview-page
…tion-summary-on-the-preview-page
@heyitsmebev just noting here as a follow-up from the last discussion we had that the message parts calculations during the sending preview were not needed for this, so it should be ready for full review as it is! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @heyitsmebev!
All looks good to me, but I wanted to check on one thing with the preview form and the adjustment with the CSRF (cross-site request forgery) piece that is removed from it. I want to be clear on that change and why it's no longer needed, or adjust if it does have to go back in.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @heyitsmebev! 🎉
The purpose of this PR is allow the user to schedule a delivery and to preview the message before sending.
As a recap, there are two pages called preview that has been created in order to display specific details of a message. In addition, the old "preview" pages have now been converted into a more general schedule page where the user can select delivery time.
This discussion here can help understand how the pages should look: #815 (comment)
On the preview page for batch jobs, user should be able to see the following:
On the preview page for one-off jobs, user should be able to see the following:
On the schedule page, user should be able to see:
Screenshots from Figma and understanding the flow: https://www.figma.com/file/aAWhlPzOP6kfVFnCCAfSZZ/notify.gov?type=design&node-id=2020-3624&mode=design&t=D1nRLZLNSXonIYCN-0
This image is to help provide an idea of what the preview page will look like when a user sends a batch message.