Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base.html created #1264

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Conversation

heyitsmebev
Copy link

@heyitsmebev heyitsmebev commented Feb 29, 2024

Description

Ticket: #1234

This PR is to consolidate templates that are no longer needed and to create several main templates: base.html and withnav_template.html. The new base.html template is currently stored under /new. As we continue to refactor and update the /template directory, we can move the new files and folders under /new.

TODO

  • Create a new base.html that consolidates templates with similar layouts
  • Create a /new directory
  • Create new directory of possible folder structures
  • The base template should contain the top nav and the footer.

QA

In order to QA this PR, you would need to pull the branch into your local environment. Search for "admin_template.html" and change the extend to "/new/base.html"

{% extends "admin_template.html" %} -> {% extends "/new/base.html" %}

A good child template to start the QA is by changing the extend in signedout.html

Notes

I also included a Templates Glossary readme file. This document serves as a glossary for the templates directory structure of the project.

Further discussions

#1234 (comment)

Based on my investigation, there are several templates that share similar layouts, therefore, we will not need some of the current layouts or we can move them to their respectable folders that make more sense.

In addition, the new base.html template will have a combination of main_template, admin_template, settings_template, and content_template.

Possible templates that could be it's own separate layout is withnav_template and org_template. Even then, we can work to simply these templates.

Old Layout Templates We Don't Need

  • withoutnav_template.html Delete
  • main_template.html Delete
  • settings_templates.html Delete
  • settings_nav.html (move to /new/navigation directory)
  • main_nav.html (move to /new/navigation directory)
  • service_navigation.html (move to /new/navigation directory)
  • org_template, could be under it's own directory called /organization
  • org_nav.html (move to /new/navigation directory)
  • content_template.html Delete and consolidate to base template

@ccostino ccostino changed the title base.hmtl created base.html created Mar 4, 2024
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyitsmebev heyitsmebev linked an issue Mar 8, 2024 that may be closed by this pull request
8 tasks
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heyitsmebev!

Also, it is awesome to see that templates_glossary.md file, thank you! ❤️ 🎉

@ccostino ccostino merged commit 25c8026 into main Mar 8, 2024
8 checks passed
@ccostino ccostino deleted the 1234-dashboard-step-1-create-new-base-template branch March 8, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard, step 1: Create new base template
3 participants