Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1216 login gov pre sign in page #1268

Merged
merged 12 commits into from
Mar 14, 2024
Merged

Conversation

jonathanbobel
Copy link
Contributor

@jonathanbobel jonathanbobel commented Mar 1, 2024

Description

This code updates the current sign-in page to include the Login.gov button and content explaining that we're switching over to Login.gov as our primary sign-in option

  • Updated front-end code for sign-in page to include Login.gov buttons and informational content
  • Alert area to show up 10 days before April 9, 2024 reminding the user they have x amount of days left to sign up
  • TODO create a follow-up ticket to remove JS after April 9th

@jonathanbobel jonathanbobel self-assigned this Mar 1, 2024
@jonathanbobel jonathanbobel linked an issue Mar 1, 2024 that may be closed by this pull request
10 tasks
@jonathanbobel
Copy link
Contributor Author

Screenshot 2024-03-01 at 11 06 26 AM
This is how the page will look with the alert

@jonathanbobel jonathanbobel added engineering UI/UX javascript Pull requests that update Javascript code redesign labels Mar 1, 2024
@jonathanbobel jonathanbobel marked this pull request as draft March 4, 2024 14:23
@jonathanbobel jonathanbobel marked this pull request as ready for review March 4, 2024 14:51
@ccostino ccostino requested a review from a team March 4, 2024 16:07
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jonathanbobel! All is looking good here so far.

Before we merge, however, let's add a few of the conditionals like we currently have on the link itself so that we can hide this until we're truly ready to turn it all on. With the conditional checks in place, this will let us deploy it and get things ready ahead of time.

I believe I have all the spots called out but please double check, and ask if anything is unclear. Thanks!

app/templates/views/signin.html Outdated Show resolved Hide resolved
app/assets/javascripts/loginAlert.js Outdated Show resolved Hide resolved
app/templates/views/signin.html Outdated Show resolved Hide resolved
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @jonathanbobel! 🎉

@ccostino ccostino merged commit f0eebfc into main Mar 14, 2024
8 checks passed
@ccostino ccostino deleted the 1216-login-gov-pre-sign-in-page branch March 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering javascript Pull requests that update Javascript code redesign UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Story: Introduce Login.gov as a sign-in option
3 participants