Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard bug #1279

Merged
merged 6 commits into from
Mar 7, 2024
Merged

dashboard bug #1279

merged 6 commits into from
Mar 7, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Mar 7, 2024

Description

Recent code related to main/view/jobs.py made the assumption that service statistics coming from the back end would have a property called 'failed', when in fact they have a property called 'failure'. This resulted in a key error which completely blew up the dashboard.

Security Considerations

N/A

@terrazoon terrazoon marked this pull request as draft March 7, 2024 17:30
@terrazoon terrazoon marked this pull request as ready for review March 7, 2024 18:31
@terrazoon terrazoon self-assigned this Mar 7, 2024
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @terrazoon!

@ccostino ccostino merged commit 7e2977f into main Mar 7, 2024
8 checks passed
@ccostino ccostino deleted the dashboard_bug branch March 7, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants