-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates with python upgrade #1284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes. Nothing major. The conversion to 3.12 doesn't seem to drastic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @samathad2023!
Due to timing/availability of folks and the fact that we now have the Python updates merged for both the API and utils repos, I'm dismissing @xlorepdarkhelm's previous review so I can merge this PR. I double checked and verified that @samathad2023 had addressed all of the requested changes and incorporated all of the feedback @xlorepdarkhelm requested. Thank you for the thorough review, @xlorepdarkhelm, and thank you @samathad2023 for making the necessary updates/improvements! 🎉 |
I've verified that the requested changes have all been made; we're looking to close this out since we merged the Python updates in the other two repos and now need the admin to run with the same version to make sure the site works properly and we can fully test everything.
Description
This PR aims to upgrade project to python version 3.12.2.This PR encompasses changes in dependencies, configurations and code modifications to ensure compatibility with Python 3.12.2 .
This should include:
install Python 3.12 via pyenv
pyenv install 3.12
Create the new virtual environment against 3.12
cd notifications-utils pyenv virtualenv 3.12 notify-admin-upgrade pyenv local notify-admin-upgrade
Update the project to use the new virtual env that is 3.12-based (in the project root directory,
pyenv local notify-admin-upgrade
)Run
make bootstrap
to install the dependencies in the new virtual env