Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates with python upgrade #1284

Merged
merged 10 commits into from
Mar 21, 2024
Merged

updates with python upgrade #1284

merged 10 commits into from
Mar 21, 2024

Conversation

samathad2023
Copy link
Contributor

@samathad2023 samathad2023 commented Mar 11, 2024

Description

This PR aims to upgrade project to python version 3.12.2.This PR encompasses changes in dependencies, configurations and code modifications to ensure compatibility with Python 3.12.2 .

This should include:

install Python 3.12 via pyenv pyenv install 3.12
Create the new virtual environment against 3.12
cd notifications-utils pyenv virtualenv 3.12 notify-admin-upgrade pyenv local notify-admin-upgrade
Update the project to use the new virtual env that is 3.12-based (in the project root directory, pyenv local notify-admin-upgrade )
Run make bootstrap to install the dependencies in the new virtual env

Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes. Nothing major. The conversion to 3.12 doesn't seem to drastic.

tests/app/main/views/test_find_users.py Outdated Show resolved Hide resolved
tests/app/main/views/test_find_users.py Outdated Show resolved Hide resolved
tests/app/models/test_base_model.py Show resolved Hide resolved
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @samathad2023!

@ccostino
Copy link
Contributor

Due to timing/availability of folks and the fact that we now have the Python updates merged for both the API and utils repos, I'm dismissing @xlorepdarkhelm's previous review so I can merge this PR.

I double checked and verified that @samathad2023 had addressed all of the requested changes and incorporated all of the feedback @xlorepdarkhelm requested. Thank you for the thorough review, @xlorepdarkhelm, and thank you @samathad2023 for making the necessary updates/improvements! 🎉

@ccostino ccostino dismissed xlorepdarkhelm’s stale review March 21, 2024 21:25

I've verified that the requested changes have all been made; we're looking to close this out since we merged the Python updates in the other two repos and now need the admin to run with the same version to make sure the site works properly and we can fully test everything.

@ccostino ccostino merged commit a1736b5 into main Mar 21, 2024
8 checks passed
@ccostino ccostino deleted the notify-admin-818 branch March 21, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants