Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting 'preview page' table Macro to HTML #1296

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

heyitsmebev
Copy link

@heyitsmebev heyitsmebev commented Mar 12, 2024

Description

I'm converting macro table on the preview page to html
https://github.com/orgs/GSA/projects/20/views/1?pane=issue&itemId=53433098

@heyitsmebev heyitsmebev marked this pull request as ready for review March 14, 2024 18:10
@heyitsmebev heyitsmebev linked an issue Mar 14, 2024 that may be closed by this pull request
@heyitsmebev heyitsmebev changed the title marco to table Converting table Marco to HTML Mar 22, 2024
Copy link
Contributor

@jonathanbobel jonathanbobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccostino ccostino changed the title Converting table Marco to HTML Converting table Macro to HTML Mar 26, 2024
@heyitsmebev heyitsmebev changed the title Converting table Macro to HTML Converting 'preview page' table Macro to HTML Mar 27, 2024
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heyitsmebev!

@ccostino ccostino merged commit 8b17ade into main Apr 3, 2024
8 checks passed
@ccostino ccostino deleted the 1215-clean-up-macros-table-on-preview-page branch April 3, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up macros table on preview page
3 participants