Add simulated numbers to allow list in trial mode #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2024 16:31
ccostino
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks, @A-Shumway42 and @terrazoon!
One quick question but not a show stopper here.
added 2 commits
March 14, 2024 10:16
…o add-sim-numbers-totrial
ccostino
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is paired with another one in api adding simulated sms numbers to the allow list while in trial mode.
The simulated numbers have to be added to the guest list of recipients in order to be passed through to the api.
TODO (optional)
Security Considerations
I don't see any concerns since we are only adding simulated numbers to the allow list. If there are potential security concerns with how the numbers are displayed in the logic I'd love to know.