Standardizing Datetimes to Numeric and Table Formats #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsmebev
changed the title
Closed
ccostino
deleted the
1283-standardize-the-dates-from-format_datetime_short-to-either-numerical-or-text
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on our style guide, datetimes should either be numeric or spelled out in tables. This PR standardizes datetimes across our app to help reduce the creation of multiple or duplicate datetime formats.
This revision includes:
format_date_shortandformat_date_short_americaformat_datetime_normalto use the 12-hour formatformat_date_shorttoformat_datetime_tableto clarify its intended use.