805 make dashboard links clickable #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 805-make-dashboard-links-clickable
…he Dashboard Landing screen. A better way to view all statuses will come with a Dashboard redesign.
heyitsmebev
requested changes
Mar 19, 2024
There was a problem hiding this comment.
I like the use of an actual button!
One styling observation: It seems like the font size was carried over from the original version with the blue box. Now, without the blue box, the font appears significantly larger in comparison to the rest. I'm curious if this was intentional. If it was, just disregard this comment. If not, I think you could bring it down .5rem or so to help it look more balanced
ccostino
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dashboard had a large clickable area that didn't look like an actual link or button that allowed the user to drill down into a Status page for their recent messages. This fix removed those areas and created one single "Details" button that is more self-explanatory and allows for the same functionality.
Additionally, I removed the section that showed failures (and the subsequent confusing link to just the failures section). The user can still click on the Details button and see the combined status page, including failures.
Upcoming designs will have data visualizations to better show the Status - all current Delivered/Pending/Failed.