Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting Header from macro to html #1344

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Converting Header from macro to html #1344

merged 3 commits into from
Apr 3, 2024

Conversation

heyitsmebev
Copy link

@heyitsmebev heyitsmebev commented Mar 22, 2024 •
edited

Description

This PR is intended to convert the header component from marco to html.

  • convert marco to html
  • simplify the header navigation and remove duplicates
  • separate out the USA banner to it's own component

@heyitsmebev heyitsmebev linked an issue Mar 25, 2024 that may be closed by this pull request
Base template: <header> component #1328
Closed
2 tasks
@ccostino ccostino changed the title Converting Header from marco to html Converting Header from macro to html Mar 28, 2024
jonathanbobel
jonathanbobel approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jonathanbobel jonathanbobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ccostino
ccostino approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heyitsmebev!

@ccostino ccostino merged commit 1c0c60a into main Apr 3, 2024
8 checks passed
@ccostino ccostino deleted the 1328-base-template-header-component branch April 3, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccostino ccostino ccostino approved these changes

@jonathanbobel jonathanbobel jonathanbobel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base template: <header> component
3 participants
@heyitsmebev @ccostino @jonathanbobel