Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move footer and head to base.html #1347

Conversation

heyitsmebev
Copy link

@heyitsmebev heyitsmebev commented Mar 25, 2024

Description

This PR is to combine the head and footer components to base.html

@heyitsmebev heyitsmebev changed the title moved footer and head to base.html move footer and head to base.html Mar 25, 2024
Copy link
Contributor

@jonathanbobel jonathanbobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heyitsmebev!

@ccostino
Copy link
Contributor

ccostino commented Apr 3, 2024

@heyitsmebev it looks like there's a conflict now due to merging another PR before this one.

@ccostino ccostino merged commit 2ede41c into main Apr 4, 2024
8 checks passed
@ccostino ccostino deleted the 1260-dashboard-step-15-use-full-width-base-template-for-landing-page branch April 4, 2024 21:14
@heyitsmebev heyitsmebev linked an issue Apr 8, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base template, step 1.5: Use full-width base template for landing page
3 participants