Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1252 missing blue boxes #1356

Merged
merged 2 commits into from
Apr 3, 2024
Merged

1252 missing blue boxes #1356

merged 2 commits into from
Apr 3, 2024

Conversation

jonathanbobel
Copy link
Contributor

Description

The styling was broken if a user clicked on "Pending" or "Failed" on a job/batch page, so I removed the conditional logic to include those in the "pill" format.

@jonathanbobel jonathanbobel marked this pull request as ready for review March 27, 2024 14:08
@jonathanbobel jonathanbobel self-assigned this Mar 27, 2024
@jonathanbobel jonathanbobel linked an issue Mar 27, 2024 that may be closed by this pull request
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@heyitsmebev heyitsmebev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jonathanbobel!

@ccostino ccostino merged commit 2d7fba0 into main Apr 3, 2024
8 checks passed
@ccostino ccostino deleted the 1252-missing-blue-boxes branch April 3, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On job page, the css for blue boxes are missing
4 participants